Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pointing of warning in WRONG_INDENTATION Rule #1024

Merged
merged 4 commits into from
Aug 3, 2021

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Aug 3, 2021

What's done:

  • Fix pointing of warning in WRONG_INDENTATION Rule
  • Add tests

### What's done:
* WIP
### What's done:
* Fix bug
### What's done:
* Polish
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1024 (7186c4a) into master (88f5d64) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1024      +/-   ##
============================================
+ Coverage     83.77%   83.80%   +0.03%     
- Complexity     2419     2424       +5     
============================================
  Files           102      102              
  Lines          6107     6108       +1     
  Branches       1808     1809       +1     
============================================
+ Hits           5116     5119       +3     
  Misses          273      273              
+ Partials        718      716       -2     
Flag Coverage Δ
unittests 83.80% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...at/ruleset/rules/chapter3/files/IndentationRule.kt 87.41% <100.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f5d64...7186c4a. Read the comment docs.

@kgevorkyan kgevorkyan marked this pull request as ready for review August 3, 2021 10:14
@kgevorkyan kgevorkyan requested a review from petertrr August 3, 2021 10:15
@kgevorkyan kgevorkyan merged commit 55b5724 into master Aug 3, 2021
@kgevorkyan kgevorkyan deleted the bugfix/incorrect_warning_offset branch August 3, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no newline at the end of file" message points to the first line and first column of the file
2 participants