Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KotlinParseException on string concatenation in fix plugin #1183

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

Cheshiriks
Copy link
Member

@Cheshiriks Cheshiriks commented Jan 24, 2022

What's done:

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1183 (acdd40f) into master (2011aff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1183   +/-   ##
=========================================
  Coverage     84.64%   84.64%           
- Complexity     2517     2519    +2     
=========================================
  Files           103      103           
  Lines          7053     7055    +2     
  Branches       1898     1899    +1     
=========================================
+ Hits           5970     5972    +2     
  Misses          302      302           
  Partials        781      781           
Flag Coverage Δ
unittests 84.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ruleset/rules/chapter3/StringConcatenationRule.kt 75.51% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2011aff...acdd40f. Read the comment docs.

@Cheshiriks Cheshiriks force-pushed the bugfix/string-concatenation-null-safe branch from 39698e1 to 35672e4 Compare January 24, 2022 10:19
### What's done:
* fixed null-safety in rule
@Cheshiriks Cheshiriks force-pushed the bugfix/string-concatenation-null-safe branch from 35672e4 to acdd40f Compare January 24, 2022 10:24
@Cheshiriks Cheshiriks merged commit c00aab9 into master Jan 24, 2022
@Cheshiriks Cheshiriks deleted the bugfix/string-concatenation-null-safe branch January 24, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KotlinParseException on string concatenation
2 participants