Bugfix: Suppress COMPLEX_EXPRESSION in .gradle.kts #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixes * Tests
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
============================================
+ Coverage 84.54% 84.55% +0.01%
- Complexity 2524 2526 +2
============================================
Files 103 103
Lines 7077 7082 +5
Branches 1913 1914 +1
============================================
+ Hits 5983 5988 +5
Misses 306 306
Partials 788 788
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Jan 30, 2022
| @@ -216,6 +218,14 @@ class NewlinesRule(configRules: List<RulesConfig>) : DiktatRule( | |||
| } | |||
| } | |||
|
|
|||
| private fun checkForComplexExpression(node: ASTNode) { | |||
| if (node.getRootNode().getFilePath().isGradleScript()) { | |||
There was a problem hiding this comment.
Where this method isGradle comes from? Is it our extension?
May be one day we can move this logic to Rule class, so it will skip some rules for some groups of patterns.
There was a problem hiding this comment.
Yes, it's from one of our utils files.
orchestr7
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #1148