Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: False-positive SMART_CAST_NEEDED with mutable properties #1196

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Jan 31, 2022

What's done:

  • Simplify rule for when conditions

### What's done:
* WIP
### What's done:
* WIP
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1196 (a45fb49) into master (d140a2e) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1196      +/-   ##
============================================
- Coverage     84.55%   84.21%   -0.34%     
+ Complexity     2526     2514      -12     
============================================
  Files           103      103              
  Lines          7082     7070      -12     
  Branches       1914     1910       -4     
============================================
- Hits           5988     5954      -34     
- Misses          306      333      +27     
+ Partials        788      783       -5     
Flag Coverage Δ
unittests 84.21% <100.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qfn/diktat/ruleset/rules/chapter4/SmartCastRule.kt 51.42% <100.00%> (-18.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d140a2e...a45fb49. Read the comment docs.

### What's done:
* Code style
@kgevorkyan kgevorkyan linked an issue Jan 31, 2022 that may be closed by this pull request
@kgevorkyan kgevorkyan marked this pull request as ready for review January 31, 2022 09:01
@kgevorkyan kgevorkyan requested a review from petertrr January 31, 2022 09:01
@kgevorkyan kgevorkyan enabled auto-merge (squash) January 31, 2022 09:16
@kgevorkyan kgevorkyan merged commit 80a366e into master Jan 31, 2022
@kgevorkyan kgevorkyan deleted the bugfix/smart_cast branch January 31, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False-positive SMART_CAST_NEEDED with mutable properties
2 participants