Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/invalid override enabled #1223

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Conversation

Arrgentum
Copy link
Member

- Corrected the order of inclusion of rules

This pull request closes #1146

Alexey Votintsev added 3 commits March 4, 2022 19:36
### What's done:
- Corrected the order of inclusion of rules

(#1146)
### What's done:
- Corrected the order of inclusion of rules

(#1146)
### What's done:
- Corrected the order of inclusion of rules

(#1146)
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1223 (740c574) into master (e8b4a51) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1223      +/-   ##
============================================
+ Coverage     83.83%   83.84%   +0.01%     
  Complexity     2536     2536              
============================================
  Files           103      103              
  Lines          7137     7136       -1     
  Branches       1937     1936       -1     
============================================
  Hits           5983     5983              
  Misses          352      352              
+ Partials        802      801       -1     
Flag Coverage Δ
unittests 83.84% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 37.25% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b4a51...740c574. Read the comment docs.

@Arrgentum Arrgentum merged commit 970f316 into master Mar 11, 2022
@Arrgentum Arrgentum deleted the bugfix/invalid_override_enabled branch March 11, 2022 09:27
@Arrgentum Arrgentum self-assigned this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usability of diktat-analysis: invalid override of rules
2 participants