Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctred NAME_ID #1306

Merged
merged 5 commits into from
May 27, 2022
Merged

Correctred NAME_ID #1306

merged 5 commits into from
May 27, 2022

Conversation

Arrgentum
Copy link
Member

@Arrgentum Arrgentum commented May 26, 2022

  • corrected NAME_ID:
    [1] rename 3 rules
    [2] update "numder" 7 rules
    [3] moved the rule ParameterNameInOuterLambdaRule down other rule list in DiktatRuleSetProvider

Issue ( #1305)

 * corrected NAME_ID

 ### Issue (#865)
@Arrgentum Arrgentum added the bug Something isn't working label May 26, 2022
@Arrgentum Arrgentum changed the title ### Whats added: Correctred NAME_ID May 26, 2022
Arrgentum added 2 commits May 26, 2022 16:12
 * corrected 1 warn test

 ### Issue (#865)
 * corrected 1 warn test

 ### Issue (#865)
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1306 (35b0e29) into master (a96e615) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1306      +/-   ##
============================================
+ Coverage     82.01%   82.05%   +0.04%     
- Complexity     2530     2533       +3     
============================================
  Files           105      105              
  Lines          7201     7201              
  Branches       2058     2058              
============================================
+ Hits           5906     5909       +3     
  Misses          346      346              
+ Partials        949      946       -3     
Flag Coverage Δ
unittests 82.05% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...leset/rules/chapter2/comments/HeaderCommentRule.kt 87.09% <ø> (ø)
...tat/ruleset/rules/chapter3/BlockStructureBraces.kt 85.50% <ø> (ø)
...at/ruleset/rules/chapter3/ConsecutiveSpacesRule.kt 93.54% <ø> (ø)
.../ruleset/rules/chapter3/files/FileStructureRule.kt 81.48% <ø> (ø)
...at/ruleset/rules/chapter3/files/IndentationRule.kt 84.47% <ø> (ø)
...iktat/ruleset/rules/chapter3/files/NewlinesRule.kt 79.46% <ø> (ø)
...tat/ruleset/rules/chapter3/files/WhiteSpaceRule.kt 81.67% <ø> (ø)
...at/ruleset/rules/chapter4/ImmutableValNoVarRule.kt 90.90% <ø> (ø)
...set/rules/chapter6/classes/StatelessClassesRule.kt 76.74% <ø> (+2.32%) ⬆️
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.50% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96e615...35b0e29. Read the comment docs.

@@ -92,6 +92,6 @@ class StatelessClassesRule(configRules: List<RulesConfig>) : DiktatRule(
}

companion object {
const val NAME_ID = "abi-multiple-init-block"
const val NAME_ID = "aaz-stateless-class"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why aaz here?

Copy link
Member

@nulls nulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orchestr7 orchestr7 enabled auto-merge (squash) May 27, 2022 08:39
@orchestr7 orchestr7 merged commit 4fa6af5 into master May 27, 2022
@orchestr7 orchestr7 deleted the bugfix/fix_Name_Id branch May 27, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants