Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added this operator references to the list with similar operator references #1393

Merged
merged 6 commits into from
Jun 22, 2022

Conversation

Arrgentum
Copy link
Member

@Arrgentum Arrgentum commented Jun 22, 2022

In logic LineLength rule in analysis long binary expressions, there are GT(>), LT(<), EQEQ(==), GTEQ(>=), LTEQ(<=), EXCLEQ(!=), but not EQEQEQ(===), EXCLEQEQEQ(!==)

Added this operator references to the list with similar operator references

This pull request closes #1392

 * Add 2 operator references

### Issue(#1392)
@Arrgentum Arrgentum self-assigned this Jun 22, 2022
 * Add 2 operator references

### Issue(#1392)
@Arrgentum Arrgentum changed the title ### Whats added: Added this operator references to the list with similar operator references Jun 22, 2022
 * Add 2 operator references

### Issue(#1392)
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1393 (9562d9f) into master (b4fed8f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1393   +/-   ##
=========================================
  Coverage     83.37%   83.37%           
  Complexity     2538     2538           
=========================================
  Files           106      106           
  Lines          7617     7617           
  Branches       2089     2089           
=========================================
  Hits           6351     6351           
  Misses          375      375           
  Partials        891      891           
Flag Coverage Δ
unittests 83.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/cqfn/diktat/ruleset/rules/chapter3/LineLength.kt 85.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4fed8f...9562d9f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 262 tests   1 247 ✔️  7m 49s ⏱️
   151 suites       15 💤
   151 files           0

Results for commit 9562d9f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

   151 files     151 suites   8m 17s ⏱️
1 262 tests 1 245 ✔️ 15 💤 2
1 264 runs  1 247 ✔️ 15 💤 2

For more details on these failures, see this check.

Results for commit 9562d9f.

♻️ This comment has been updated with latest results.

 * Add 2 operator references
 * Corrected comment

### Issue(#1393)
Arrgentum and others added 2 commits June 22, 2022 19:17
 * Add 2 operator references
 * Corrected comment

### Issue(#1393)
@Arrgentum Arrgentum enabled auto-merge (squash) June 22, 2022 16:46
@Arrgentum Arrgentum merged commit 75bf80f into master Jun 22, 2022
@Arrgentum Arrgentum deleted the bugfix/AddInLongLineAnalysisEQEQEQAndEXCLEQEQEQ branch June 22, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in LineLength rule analysis two operator references
2 participants