Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set extendedIndentAfterOperators to true by default #1447

Merged

Conversation

0x6675636b796f75676974687562
Copy link
Member

What's done:

Which rule and warnings did you add?

Actions checklist

  • Updated diktat-analysis.yml

### What's done:

 * Once we now have a separate flag for assignment
   (`extendedIndentForExpressionBodies`, `false` by default), let's set
   `extendedIndentAfterOperators` back to `true` to be consistent with how IDEA
   formats Kotlin source files.
### What's done:
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1447 (1db5ab5) into master (0890bd6) will not change coverage.
The diff coverage is 59.02%.

@@            Coverage Diff            @@
##             master    #1447   +/-   ##
=========================================
  Coverage     83.23%   83.23%           
  Complexity     2562     2562           
=========================================
  Files           107      107           
  Lines          7619     7619           
  Branches       2103     2103           
=========================================
  Hits           6342     6342           
  Misses          388      388           
  Partials        889      889           
Flag Coverage Δ
unittests 83.23% <59.02%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 74.10% <ø> (ø)
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 53.19% <0.00%> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 98.08% <ø> (ø)
...n/diktat/ruleset/rules/chapter3/MagicNumberRule.kt 83.01% <0.00%> (ø)
.../ruleset/rules/chapter3/StringConcatenationRule.kt 73.19% <0.00%> (ø)
...diktat/ruleset/rules/chapter3/TrailingCommaRule.kt 94.33% <ø> (ø)
...tat/ruleset/rules/chapter3/WhenMustHaveElseRule.kt 75.71% <0.00%> (ø)
...qfn/diktat/ruleset/rules/chapter4/SmartCastRule.kt 50.71% <0.00%> (ø)
.../cqfn/diktat/ruleset/rules/chapter5/CustomLabel.kt 85.71% <0.00%> (ø)
...cqfn/diktat/ruleset/rules/chapter6/UseLastIndex.kt 91.30% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0890bd6...1db5ab5. Read the comment docs.

@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 287 tests   1 272 ✔️  1m 16s ⏱️
   159 suites       15 💤
   159 files           0

Results for commit 1db5ab5.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 287 tests   1 272 ✔️  1m 15s ⏱️
   159 suites       15 💤
   159 files           0

Results for commit 1db5ab5.

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 deleted the bugfix/andrey.shcheglov/indentation branch July 13, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants