-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gradle-plugin] use empty string as default value for reporter type #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixed test
petertrr
changed the title
Use empty string as default value for reporter type
[gradle-plugin] use empty string as default value for reporter type
Jul 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
============================================
- Coverage 83.23% 82.62% -0.62%
+ Complexity 2562 2542 -20
============================================
Files 107 104 -3
Lines 7619 7471 -148
Branches 2103 2086 -17
============================================
- Hits 6342 6173 -169
- Misses 388 435 +47
+ Partials 889 863 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Extract `createReporterFlag` method * Add test
0x6675636b796f75676974687562
approved these changes
Jul 19, 2022
0x6675636b796f75676974687562
added
the
plugins
Plugins for build systems to allow them to run diktat
label
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1426 we've introduced a warning, that is currently being logged in unintended cases, because default value of
reporterType
is a non-empty string:However, reporter type is not set explicitly so for the end user the warning makes no sense.
With an empty string as the default there will be no warning and diktat will fall back to using
plain
reporter according to theDiktatJavaExecTaskBase#setReporter
method