Add the retry logic and diagnostics to DiktatSaveSmokeTest
#1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * JAVA_HOME is now correctly set for child processes (works around compatibility problems with Java 17). * Added the retry logic for download and delete operations. * Added test timeouts of 20s. * Added debug logging. * Dropped the dependency on Apache HttpClient (not really necessary). * See #1476.
0x6675636b796f75676974687562
requested review from
Cheshiriks,
petertrr,
nulls,
orchestr7 and
icemachined
unix-junkie
approved these changes
Jul 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
=========================================
Coverage 82.96% 82.96%
Complexity 2579 2579
=========================================
Files 111 111
Lines 7708 7708
Branches 2111 2111
=========================================
Hits 6395 6395
Misses 418 418
Partials 895 895
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
### What's done: * See #1476.
petertrr
approved these changes
Jul 26, 2022
### What's done: * See #1476.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
JAVA_HOMEis now correctly set for child processes (works aroundcompatibility problems with Java 17).
DiktatSaveSmokeTest.beforeAll#1476.