Improve JAVA_HOME comparison for forked tests
#1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Now, `/path/to/jdk` and `/path/to/jdk/jre` are considered the same `JAVA_HOME`.
### What's done:
petertrr
approved these changes
Jul 27, 2022
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
=========================================
Coverage 82.96% 82.96%
Complexity 2579 2579
=========================================
Files 111 111
Lines 7708 7708
Branches 2111 2111
=========================================
Hits 6395 6395
Misses 418 418
Partials 895 895
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
/path/to/jdkand/path/to/jdk/jreare considered the sameJAVA_HOME.