WRONG_OVERLOADING_FUNCTION_ARGUMENTS: adding exceptions to the rule #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - rule will be triggered if and only if it has same modifiers
orchestr7
force-pushed
the
bugfix/overloading
branch
from
5b2d1f2
to
c3c5f5c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
### What's done: - rule will be triggered if and only if it has same modifiers
### What's done: - rule will be triggered if and only if it has same modifiers
orchestr7
force-pushed
the
bugfix/overloading
branch
from
43324e9
to
4515dc3
Compare
orchestr7
commented
Sep 14, 2022
...les/src/test/kotlin/org/cqfn/diktat/ruleset/chapter5/OverloadingArgumentsFunctionWarnTest.kt
Show resolved
Hide resolved
### What's done: - rule will be triggered if and only if it has same modifiers
nulls
reviewed
Sep 14, 2022
...rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter5/OverloadingArgumentsFunction.kt
Outdated
Show resolved
Hide resolved
nulls
approved these changes
Sep 14, 2022
### What's done: - rule will be triggered if and only if it has same modifiers
### What's done: - rule will be triggered if and only if it has same modifiers
### What's done: - rule will be triggered if and only if it has same modifiers
### What's done: - rule will be triggered if and only if it has same modifiers
### What's done: - rule will be triggered if and only if it has same modifiers
orchestr7
force-pushed
the
bugfix/overloading
branch
from
5ab42d3
to
dc0e02e
Compare
### What's done: - rule will be triggered if and only if it has same modifiers
orchestr7
force-pushed
the
bugfix/overloading
branch
from
827f864
to
8ac1b7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1520 +/- ##
============================================
- Coverage 82.56% 82.55% -0.01%
- Complexity 2566 2577 +11
============================================
Files 111 111
Lines 7716 7735 +19
Branches 2119 2125 +6
============================================
+ Hits 6371 6386 +15
Misses 443 443
- Partials 902 906 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: