Bugfix for fix mode of AVOID_NULL_CHECK
#1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done:
* Added isAssignment utility function to check if a line has assignment operator ('=') using simple regex
* Added a check for assignment operator when deciding if to put run block or not
* Added tests
(#1293)
sanyavertolet
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/StringUtils.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
============================================
+ Coverage 83.00% 83.01% +0.01%
- Complexity 2362 2363 +1
============================================
Files 111 111
Lines 7753 7760 +7
Branches 2008 2009 +1
============================================
+ Hits 6435 6442 +7
Misses 439 439
Partials 879 879
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
### What's done:
* Added isAssignment utility function to check if a line has assignment operator ('=') using simple regex
* Added a check for assignment operator when deciding if to put run block or not
* Added tests
(#1293)
### What's done:
* Added isAssignment utility function to check if a line has assignment operator ('=') using simple regex
* Added a check for assignment operator when deciding if to put run block or not
* Added tests
(#1293)
petertrr
reviewed
Oct 26, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/StringUtils.kt
Outdated
Show resolved
Hide resolved
### What's done: * Added a check for assignment operator when deciding if to put run block or not * Added tests (#1293)
### What's done: * Added a check for assignment operator when deciding if to put run block or not * Added tests (#1293)
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Show resolved
Hide resolved
0x6675636b796f75676974687562
approved these changes
Oct 27, 2022
petertrr
approved these changes
Oct 27, 2022
nulls
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Bugfix for fix mode of AVOID_NULL_CHECK * Added a check for assignment operator when deciding if to put run block or not * Added tests (#1293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1293
What's done: