Make DiktatRuleSetProvider#get() lazy
#1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - Fixes #1548. - Since Diktat rules have no mutable state, it's safe to reuse them for checking multiple files.
0x6675636b796f75676974687562
requested review from
kgevorkyan,
orchestr7,
petertrr and
icemachined
and removed request for
orchestr7
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
=========================================
Coverage 82.11% 82.12%
+ Complexity 2311 2309 -2
=========================================
Files 112 112
Lines 7835 7837 +2
Branches 2030 2030
=========================================
+ Hits 6434 6436 +2
Misses 481 481
Partials 920 920
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sanyavertolet
approved these changes
Nov 7, 2022
0x6675636b796f75676974687562
added a commit
that referenced
this pull request
Nov 9, 2022
0x6675636b796f75676974687562
added a commit
that referenced
this pull request
Nov 9, 2022
0x6675636b796f75676974687562
added a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: