Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block version of kaml-jvm #1580

Merged
merged 3 commits into from
Nov 29, 2022
Merged

block version of kaml-jvm #1580

merged 3 commits into from
Nov 29, 2022

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 25, 2022

What's done:

  • block version of kaml-jvm to have same version of serialization as in ktlint

### What's done:
* block version of kaml-jvm to have same version of serialization as in ktlint
@nulls nulls self-assigned this Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1580 (7a5e9da) into master (2074eeb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1580   +/-   ##
=========================================
  Coverage     82.43%   82.43%           
  Complexity     2323     2323           
=========================================
  Files           112      112           
  Lines          7845     7845           
  Branches       2034     2034           
=========================================
  Hits           6467     6467           
  Misses          453      453           
  Partials        925      925           
Flag Coverage Δ
unittests 82.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 007 tests   1 992 ✔️  22m 1s ⏱️
   165 suites       15 💤
   165 files           0

Results for commit 7a5e9da.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files     164 suites   36m 57s ⏱️
1 988 tests 1 969 ✔️ 15 💤 4
1 992 runs  1 973 ✔️ 15 💤 4

For more details on these failures, see this check.

Results for commit 7a5e9da.

♻️ This comment has been updated with latest results.

@nulls nulls enabled auto-merge (squash) November 28, 2022 19:57
@petertrr
Copy link
Member

same version of serialization as in ktlint

What exactly was the problem with this? Also, does ktlint use kx.serialization at all? Or is there any transitive dependency that gets overridden?

@nulls
Copy link
Member Author

nulls commented Nov 29, 2022

same version of serialization as in ktlint

What exactly was the problem with this? Also, does ktlint use kx.serialization at all? Or is there any transitive dependency that gets overridden?

ktlint uses detekt sarif4k which uses kx.serialization (old version). detekt sarif4k already have a change with upgrading kx.serialization (0.2.0), but ktlint will be upgraded in version 0.48.x and more. So we will able to upgrade kaml after upgrading ktlint

@nulls nulls merged commit 6728425 into master Nov 29, 2022
@nulls nulls deleted the feature/kaml-downgrade branch November 29, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants