Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled additional rules from KtLint #1643

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

nulls
Copy link
Member

@nulls nulls commented Mar 24, 2023

What's done:

  • updated disabled_rules
  • updated exclusion in gradle plugin

It extracted from #1571

### What's done:
- updated `disabled_rules`
- updated exclusion in gradle tasks

It extracted from #1571

Co-authored-by: Andrey Shcheglov <andrewbass+saveourtool@gmail.com>
@nulls nulls self-assigned this Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1643 (bed40dd) into master (e4e6465) will decrease coverage by 0.09%.
The diff coverage is 56.52%.

@@             Coverage Diff              @@
##             master    #1643      +/-   ##
============================================
- Coverage     81.40%   81.31%   -0.09%     
  Complexity     2326     2326              
============================================
  Files           112      113       +1     
  Lines          7894     7912      +18     
  Branches       2048     2048              
============================================
+ Hits           6426     6434       +8     
- Misses          568      578      +10     
  Partials        900      900              
Impacted Files Coverage Δ
...otlin/org/cqfn/diktat/common/ktlint/KtLintUtils.kt 0.00% <0.00%> (ø)
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt 100.00% <100.00%> (ø)
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt 100.00% <100.00%> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 77.65% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   161 files  ±0     161 suites  ±0   5m 25s ⏱️ -48s
1 367 tests ±0  1 331 ✔️ ±0  36 💤 ±0  0 ±0 
2 746 runs  ±0  2 710 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit a5e9f97. ± Comparison against base commit d6e9848.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   161 files  ±0     161 suites  ±0   6m 56s ⏱️ -54s
1 367 tests ±0  1 350 ✔️ ±0  17 💤 ±0  0 ±0 
2 746 runs  ±0  2 729 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit a5e9f97. ± Comparison against base commit d6e9848.

@nulls nulls enabled auto-merge (squash) March 24, 2023 10:40
@nulls nulls added this to the 2.0.0 milestone Mar 24, 2023
@nulls nulls mentioned this pull request Mar 24, 2023
4 tasks
@nulls nulls merged commit d2a22f0 into master Mar 27, 2023
@nulls nulls deleted the feature/ktlint-disabled-rules#1571 branch March 27, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants