Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IdentifierNaming #1746

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Fixed IdentifierNaming #1746

merged 6 commits into from
Sep 25, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Sep 22, 2023

What's done:

  • added toDeterministic() for repeatable functions
  • fixed isFixMode and canBeAutoCorrected

It's part of #1737

### What's done:
- added toDeterministic() for repeatable functions
- fixed isFixMode and canBeAutoCorrected

It's part of #1737
@nulls nulls added bug Something isn't working tests Improve testing labels Sep 22, 2023
@nulls nulls added this to the 2.0.0 milestone Sep 22, 2023
@nulls nulls self-assigned this Sep 22, 2023
@nulls nulls enabled auto-merge (squash) September 22, 2023 12:54
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 21s ⏱️ - 2m 12s
1 378 tests ±0  1 317 ✔️ +3  61 💤  - 3  0 ±0 
2 757 runs  ±0  2 695 ✔️ +3  62 💤  - 3  0 ±0 

Results for commit 1e41d01. ± Comparison against base commit feeeee9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 12s ⏱️ -31s
1 378 tests ±0  1 329 ✔️ +3  49 💤  - 3  0 ±0 
2 757 runs  ±0  2 707 ✔️ +3  50 💤  - 3  0 ±0 

Results for commit 1e41d01. ± Comparison against base commit feeeee9.

♻️ This comment has been updated with latest results.

@kgevorkyan
Copy link
Member

so many broken tests, why we are even update ktlint to 1.0 before release of diktat 😬

@nulls
Copy link
Member Author

nulls commented Sep 22, 2023

so many broken tests, why we are even update ktlint to 1.0 before release of diktat 😬

we upgraded ktlint to 1.0 to have a release version in diktat 2.0

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1746 (1e41d01) into master (feeeee9) will increase coverage by 0.08%.
The diff coverage is 84.21%.

@@             Coverage Diff              @@
##             master    #1746      +/-   ##
============================================
+ Coverage     75.94%   76.02%   +0.08%     
+ Complexity     2282     2281       -1     
============================================
  Files           126      126              
  Lines          8234     8242       +8     
  Branches       2068     2069       +1     
============================================
+ Hits           6253     6266      +13     
+ Misses         1063     1060       -3     
+ Partials        918      916       -2     
Files Changed Coverage Δ
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 80.95% <84.21%> (+1.24%) ⬆️

... and 1 file with indirect coverage changes

@nulls nulls merged commit 41265dc into master Sep 25, 2023
32 checks passed
@nulls nulls deleted the feature/fix-tests#1737_2 branch September 25, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants