-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed IdentifierNaming #1746
Fixed IdentifierNaming #1746
Conversation
### What's done: - added toDeterministic() for repeatable functions - fixed isFixMode and canBeAutoCorrected It's part of #1737
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Fixed
Show fixed
Hide fixed
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 6m 21s ⏱️ - 2m 12s Results for commit 1e41d01. ± Comparison against base commit feeeee9. ♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 7m 12s ⏱️ -31s Results for commit 1e41d01. ± Comparison against base commit feeeee9. ♻️ This comment has been updated with latest results. |
so many broken tests, why we are even update ktlint to 1.0 before release of diktat 😬 |
we upgraded ktlint to 1.0 to have a release version in diktat 2.0 |
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
============================================
+ Coverage 75.94% 76.02% +0.08%
+ Complexity 2282 2281 -1
============================================
Files 126 126
Lines 8234 8242 +8
Branches 2068 2069 +1
============================================
+ Hits 6253 6266 +13
+ Misses 1063 1060 -3
+ Partials 918 916 -2
|
What's done:
It's part of #1737