Fixed LineLength #1759
Merged
Fixed LineLength #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - Fixed bug when fix-result of rule `LineLength` execution still contained `LineLength` warnings. To fix this, added loop that trying to fix `LineLength` warnings until warnings run out. - Added `unFix()` method realization inside `FunAndProperty` and `ValueArgumentList` classes to undo unnecessary fixes. - Fixed bug for case when long comment followed multiline property initialization. - Fixed and reworked several fix tests. It's part of saveourtool#1737
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
============================================
+ Coverage 77.09% 78.25% +1.15%
- Complexity 2376 2410 +34
============================================
Files 126 126
Lines 8408 8451 +43
Branches 2131 2148 +17
============================================
+ Hits 6482 6613 +131
+ Misses 976 880 -96
- Partials 950 958 +8
|
nulls
reviewed
Oct 5, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Outdated
Show resolved
Hide resolved
kgevorkyan
reviewed
Oct 5, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Show resolved
Hide resolved
nulls
reviewed
Oct 5, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Outdated
Show resolved
Hide resolved
nulls
reviewed
Oct 5, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Outdated
Show resolved
Hide resolved
kgevorkyan
reviewed
Oct 5, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Show resolved
Hide resolved
kgevorkyan
approved these changes
Oct 5, 2023
kgevorkyan
reviewed
Oct 6, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Outdated
Show resolved
Hide resolved
nulls
reviewed
Oct 9, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/LineLength.kt
Show resolved
Hide resolved
nulls
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
LineLengthexecution still containedLineLengthwarnings. To fix this, added loop that trying to fixLineLengthrule warnings until warnings run out.MAX_FIX_NUMBERfor limit on fixing to avoid infinite loop. If the limit is reached, then error message is displayed.unFix()method realization insideFunAndPropertyandValueArgumentListclasses to undo incorrect unnecessary fixes.It's part of #1737