Fixed false positive MISSING_KDOC_ON_FUNCTION on local function (function inside another function)
#1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * fix
…ield. - added `ASTNode.isPrivate()`, `ASTNode.hasSetterGetter()` methods - added `isPairPropertyBackingField(propertyNode: ASTNode?, backingFieldNode: ASTNode?)` function - added warning tests. Closes #1709
* WIP
* Merge master
- Fixed false positive `MISSING_KDOC_ON_FUNCTION` on local function (function inside another function) - Added warning test Closes #1773
orchestr7
reviewed
Dec 7, 2023
diktat-rules/src/test/kotlin/com/saveourtool/diktat/ruleset/chapter2/KdocMethodsTest.kt
Show resolved
Hide resolved
orchestr7
reviewed
Dec 7, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1848 +/- ##
============================================
+ Coverage 78.43% 78.45% +0.02%
- Complexity 2434 2439 +5
============================================
Files 133 133
Lines 8616 8624 +8
Branches 2171 2174 +3
============================================
+ Hits 6758 6766 +8
Misses 896 896
Partials 962 962 ☔ View full report in Codecov by Sentry. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 7m 29s ⏱️ -11s Results for commit 325134d. ± Comparison against base commit 5511527. ♻️ This comment has been updated with latest results. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 10m 52s ⏱️ + 4m 50s Results for commit 325134d. ± Comparison against base commit 5511527. ♻️ This comment has been updated with latest results. |
orchestr7
reviewed
Dec 7, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
kgevorkyan
approved these changes
Dec 7, 2023
DrAlexD
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
MISSING_KDOC_ON_FUNCTIONon local function (function inside another function)Closes #1773