Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exit code 1 when not all errors are fixed #1868

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

nulls
Copy link
Member

@nulls nulls commented Dec 15, 2023

What's done:

  • calculate only not fixed errors
  • return 1 when there are errors

### What's done:
- calculate only not fixed errors
- return 1 when there are errors
@nulls nulls added this to the 2.0.0 milestone Dec 15, 2023
@nulls nulls self-assigned this Dec 15, 2023
@nulls nulls enabled auto-merge (squash) December 15, 2023 16:11
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   166 files  ±0     166 suites  ±0   6m 32s ⏱️ + 1m 33s
1 426 tests ±0  1 382 ✔️  - 6  38 💤 ±0  6 +6 
2 805 runs  ±0  2 761 ✔️  - 6  38 💤 ±0  6 +6 

For more details on these failures, see this check.

Results for commit 45acaca. ± Comparison against base commit 8b44e13.

Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   166 files  ±0     166 suites  ±0   7m 21s ⏱️ -10s
1 426 tests ±0  1 403 ✔️  - 6  17 💤 ±0  6 +6 
2 805 runs  ±0  2 782 ✔️  - 6  17 💤 ±0  6 +6 

For more details on these failures, see this check.

Results for commit 45acaca. ± Comparison against base commit 8b44e13.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3ba0fb0) 78.42% compared to head (348c702) 78.40%.

Files Patch % Lines
...c/main/kotlin/com/saveourtool/diktat/DiktatMain.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1868      +/-   ##
============================================
- Coverage     78.42%   78.40%   -0.02%     
  Complexity     2465     2465              
============================================
  Files           134      134              
  Lines          8695     8697       +2     
  Branches       2199     2200       +1     
============================================
  Hits           6819     6819              
- Misses          897      899       +2     
  Partials        979      979              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nulls nulls merged commit b3cd098 into master Dec 18, 2023
18 of 19 checks passed
@nulls nulls deleted the bugfix/exit-code branch December 18, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants