Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplicate @property generation for parameter with ' in name #1873

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fixed duplicate @property generation for parameter with ' in name #1873

merged 3 commits into from
Dec 18, 2023

Conversation

DrAlexD
Copy link
Member

@DrAlexD DrAlexD commented Dec 18, 2023

What's done:

  • fixed bug.
  • added fix tests.

Closes #1719

@DrAlexD
Fixed duplicate @property generation for parameter with ' in name
2cdde3c 
### What's done:
- fixed bug.
- added fix tests.

Closes #1719
@DrAlexD DrAlexD self-assigned this Dec 18, 2023
@DrAlexD DrAlexD added the bug Something isn't working label Dec 18, 2023
@DrAlexD DrAlexD added this to the 2.0.0 milestone Dec 18, 2023
@DrAlexD DrAlexD enabled auto-merge (squash) December 18, 2023 11:07
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (beb9960) 78.35% compared to head (ca8dddf) 78.32%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1873      +/-   ##
============================================
- Coverage     78.35%   78.32%   -0.03%     
+ Complexity     2465     2458       -7     
============================================
  Files           134      134              
  Lines          8703     8696       -7     
  Branches       2203     2201       -2     
============================================
- Hits           6819     6811       -8     
- Misses          905      906       +1     
  Partials        979      979

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   166 files  ±0     166 suites  ±0   7m 17s ⏱️ - 1m 44s
1 426 tests ±0  1 388 ✔️ ±0  38 💤 ±0  0 ❌ ±0 
2 805 runs  ±0  2 767 ✔️ ±0  38 💤 ±0  0 ❌ ±0 

Results for commit 2cdde3c. ± Comparison against base commit b3cd098.

@github-actions GitHub Actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   166 files  ±0     166 suites  ±0   7m 8s ⏱️ -14s
1 426 tests ±0  1 409 ✔️ ±0  17 💤 ±0  0 ❌ ±0 
2 805 runs  ±0  2 788 ✔️ ±0  17 💤 ±0  0 ❌ ±0 

Results for commit 2cdde3c. ± Comparison against base commit b3cd098.

@DrAlexD DrAlexD merged commit e51bcf6 into master Dec 18, 2023
19 checks passed
@DrAlexD DrAlexD deleted the bugifx/property_duplicate branch December 18, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgevorkyan kgevorkyan kgevorkyan approved these changes

@nulls nulls nulls approved these changes

@diphtongue diphtongue Awaiting requested review from diphtongue

Assignees

@DrAlexD DrAlexD

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Generates duplicate @property for parameter with ' in name
3 participants
@DrAlexD @nulls @kgevorkyan