Bugfix. Unhandled ArrayStoreException when string template has [] operator inside #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixed bugs
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
============================================
- Coverage 81.90% 81.88% -0.03%
- Complexity 1633 1635 +2
============================================
Files 78 78
Lines 4118 4123 +5
Branches 1300 1302 +2
============================================
+ Hits 3373 3376 +3
Misses 219 219
- Partials 526 528 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Nov 16, 2020
| || node.treeNext.elementType == CLOSING_QUOTE | ||
| } else { | ||
| || node.treeNext.elementType == CLOSING_QUOTE) | ||
| } else if(!isArrayAccessExpression) { |
There was a problem hiding this comment.
you will need to check for more corner cases - this can be not the only problem here
aktsay6
deleted the
bugfix/string-template-array-store-exception(#406)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #406