Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing replaceWithText() method with rawReplaceWithText() #939

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

orchestr7
Copy link
Member

What's done:

  • workaround for ktlint bug (when Service for indents is not provided)

### What's done:
- workaround for ktlint bug (when Service for indents is not provided)
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #939 (d7f9ce7) into master (91864bd) will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #939   +/-   ##
=========================================
  Coverage     84.15%   84.15%           
  Complexity     2375     2375           
=========================================
  Files           101      101           
  Lines          6010     6010           
  Branches       1773     1773           
=========================================
  Hits           5058     5058           
  Misses          263      263           
  Partials        689      689           
Flag Coverage Δ
unittests 84.15% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt 85.18% <0.00%> (ø)
...g/cqfn/diktat/ruleset/rules/chapter3/EmptyBlock.kt 74.50% <0.00%> (ø)
...at/ruleset/rules/chapter3/files/IndentationRule.kt 85.91% <0.00%> (ø)
...iktat/ruleset/rules/chapter3/files/NewlinesRule.kt 78.35% <ø> (ø)
.../ruleset/rules/chapter2/kdoc/CommentsFormatting.kt 72.50% <75.00%> (ø)
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 83.73% <90.00%> (ø)
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt 90.90% <100.00%> (ø)
...leset/rules/chapter2/comments/HeaderCommentRule.kt 86.59% <100.00%> (ø)
...at/ruleset/rules/chapter3/AnnotationNewLineRule.kt 96.42% <100.00%> (ø)
...tat/ruleset/rules/chapter3/BlockStructureBraces.kt 85.47% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91864bd...d7f9ce7. Read the comment docs.

### What's done:
- adding information about the file and node for critical errors
### What's done:
- adding information about the file and node for critical errors
@orchestr7 orchestr7 merged commit 2f96c88 into master Jun 23, 2021
@petertrr petertrr deleted the feature/replace-text branch July 1, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants