Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRONG_NAME_OF_VARIABLE_INSIDE_ACCESSOR false positive trigger #943

Merged
merged 4 commits into from
Jun 30, 2021

Conversation

Cheshiriks
Copy link
Member

What's done:

@Cheshiriks Cheshiriks requested a review from petertrr June 28, 2021 14:50
### What's done:
* fixed false positive trigger
Closes #940
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #943 (d47fb3d) into master (1bf6e43) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #943      +/-   ##
============================================
- Coverage     84.14%   84.12%   -0.03%     
- Complexity     2382     2388       +6     
============================================
  Files           101      101              
  Lines          6025     6027       +2     
  Branches       1779     1781       +2     
============================================
  Hits           5070     5070              
  Misses          263      263              
- Partials        692      694       +2     
Flag Coverage Δ
unittests 84.12% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/ruleset/rules/chapter6/PropertyAccessorFields.kt 73.91% <33.33%> (-7.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf6e43...d47fb3d. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add check whether the property is an extension property. field keyword is unresolvable in this case and this rule shouldn't be executed

fixed false positive trigger
Closes #940
@Cheshiriks Cheshiriks merged commit 578f2a5 into master Jun 30, 2021
@petertrr petertrr deleted the bugfix/field-rule branch July 1, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WRONG_NAME_OF_VARIABLE_INSIDE_ACCESSOR false positive trigger
3 participants