Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging of file name in DiktatRule is unreliable #948

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

Cheshiriks
Copy link
Member

What's done:

### What's done:
* added getRootNode() and require in getFilePath()
Closes #938
@Cheshiriks Cheshiriks requested a review from petertrr July 1, 2021 11:34
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #948 (822fe8a) into master (0786d51) will decrease coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #948      +/-   ##
============================================
- Coverage     84.12%   84.11%   -0.02%     
  Complexity     2389     2389              
============================================
  Files           101      101              
  Lines          6029     6030       +1     
  Branches       1782     1783       +1     
============================================
  Hits           5072     5072              
  Misses          263      263              
- Partials        694      695       +1     
Flag Coverage Δ
unittests 84.11% <81.81%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cqfn/diktat/ruleset/rules/chapter6/RunInScript.kt 92.30% <50.00%> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 85.43% <66.66%> (-0.34%) ⬇️
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt 91.08% <100.00%> (ø)
...leset/rules/chapter2/comments/HeaderCommentRule.kt 86.59% <100.00%> (ø)
...diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt 85.18% <100.00%> (ø)
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt 88.67% <100.00%> (ø)
...n/diktat/ruleset/rules/chapter3/MagicNumberRule.kt 89.58% <100.00%> (ø)
...diktat/ruleset/rules/chapter6/AvoidUtilityClass.kt 77.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0786d51...822fe8a. Read the comment docs.

### What's done:
* added getRootNode() and require in getFilePath()
Closes #938
@Cheshiriks Cheshiriks merged commit 6dec699 into master Jul 1, 2021
@kgevorkyan kgevorkyan deleted the feature/logging-of-file-name branch July 1, 2021 13:38
@kgevorkyan kgevorkyan restored the feature/logging-of-file-name branch July 1, 2021 13:38
@kgevorkyan kgevorkyan deleted the feature/logging-of-file-name branch July 1, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging of file name in DiktatRule is unreliable
2 participants