Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic of InlineClassesRule #958

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jul 2, 2021

Do not suggest to use inline class on versions greater than 1.5.0 and on interfaces

What's done:

  • Changed logic
  • Added tests

This pull request closes #904

Proper support for value classes should be added in #957

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #958 (07fedd0) into master (0028f77) will increase coverage by 4.12%.
The diff coverage is 87.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #958      +/-   ##
============================================
+ Coverage     79.75%   83.88%   +4.12%     
- Complexity     2016     2394     +378     
============================================
  Files            97      101       +4     
  Lines          5074     6050     +976     
  Branches       1621     1788     +167     
============================================
+ Hits           4047     5075    +1028     
- Misses          246      265      +19     
+ Partials        781      710      -71     
Flag Coverage Δ
unittests 83.88% <87.25%> (+4.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ktat/common/config/reader/ApplicationProperties.kt 0.00% <0.00%> (ø)
...t/common/config/reader/JsonResourceConfigReader.kt 45.45% <ø> (ø)
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt 100.00% <ø> (ø)
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 74.13% <ø> (-4.81%) ⬇️
...n/kotlin/org/cqfn/diktat/ruleset/utils/PsiUtils.kt 50.00% <ø> (+4.54%) ⬆️
...eset/utils/indentation/CustomIndentationChecker.kt 100.00% <ø> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt 35.29% <15.38%> (-6.17%) ⬇️
.../kotlin/org/cqfn/diktat/ruleset/utils/KdocUtils.kt 20.00% <20.00%> (+4.21%) ⬆️
.../cqfn/diktat/ruleset/utils/indentation/Checkers.kt 74.77% <44.44%> (-2.90%) ⬇️
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 61.90% <45.45%> (-13.10%) ⬇️
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b464a3a...07fedd0. Read the comment docs.

@petertrr petertrr merged commit 30018f3 into master Jul 2, 2021
@petertrr petertrr deleted the bugfix/inline-on-interfaces#904 branch July 2, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INLINE_CLASS_CAN_BE_USED] inline class can be used
2 participants