Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for fixes from SARIF into FixPlugin #474

Merged
merged 22 commits into from
Jan 12, 2023
Merged

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Jan 11, 2023

What's done:

  • Enable sarif library
  • Refactor methods - split into little one
  • Add test for sarif mode in FixPlugin

### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
@kgevorkyan kgevorkyan linked an issue Jan 11, 2023 that may be closed by this pull request
### What's done:
* WIP
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #474 (8a5885a) into main (a846ce9) will decrease coverage by 0.13%.
The diff coverage is 56.06%.

@@             Coverage Diff              @@
##               main     #474      +/-   ##
============================================
- Coverage     47.70%   47.57%   -0.14%     
- Complexity      149      153       +4     
============================================
  Files            53       53              
  Lines          1790     1814      +24     
  Branches        313      313              
============================================
+ Hits            854      863       +9     
- Misses          807      821      +14     
- Partials        129      130       +1     
Flag Coverage Δ
unittests 47.57% <56.06%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/saveourtool/save/plugins/fix/FixPluginConfig.kt 44.44% <50.00%> (+0.85%) ⬆️
...tlin/com/saveourtool/save/plugins/fix/FixPlugin.kt 57.66% <57.40%> (-3.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

### What's done:
* WIP
@github-actions
Copy link

github-actions bot commented Jan 12, 2023

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

241 tests  +2   217 ✔️ +2   9m 28s ⏱️ +58s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 8a5885a. ± Comparison against base commit bc2f039.

♻️ This comment has been updated with latest results.

### What's done:
* WIP
### What's done:
* WIP
@kgevorkyan kgevorkyan marked this pull request as ready for review January 12, 2023 10:28
@github-actions
Copy link

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

241 tests  +2   217 ✔️ +2   17m 10s ⏱️ +42s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 8a5885a. ± Comparison against base commit bc2f039.

@github-actions
Copy link

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

241 tests  +2   217 ✔️ +3   10m 14s ⏱️ -22s
  48 suites ±0     24 💤 ±0 
  48 files   ±0       0  - 1 

Results for commit 8a5885a. ± Comparison against base commit bc2f039.

@kgevorkyan kgevorkyan requested a review from nulls January 12, 2023 11:28
@kgevorkyan kgevorkyan merged commit 69b23ee into main Jan 12, 2023
@kgevorkyan kgevorkyan deleted the feature/add_fixpatches branch January 12, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a library for applying of SARIF fix patches
2 participants