FixPlugin: Compare test files in course of building the TestResults by full paths #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y full paths * Added test fore tests with the same name Closes #473
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
============================================
+ Coverage 47.02% 47.25% +0.23%
- Complexity 152 154 +2
============================================
Files 53 53
Lines 1814 1822 +8
Branches 313 314 +1
============================================
+ Hits 853 861 +8
Misses 831 831
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kgevorkyan
reviewed
Jan 17, 2023
save-plugins/fix-plugin/src/commonMain/kotlin/com/saveourtool/save/plugins/fix/FixPlugin.kt
Outdated
Show resolved
Hide resolved
kgevorkyan
approved these changes
Jan 18, 2023
| .substringAfter(Path.DIRECTORY_SEPARATOR) | ||
| .toPath() | ||
|
|
||
| val testCopy = test.createRelativePathToTheRoot(testConfig.getRootConfig().directory).toPath() |
There was a problem hiding this comment.
Should it be called testCopy? I think it original test file
| @@ -247,6 +247,17 @@ class FixPlugin( | |||
| ) | |||
| } | |||
|
|
|||
| private fun isComparingTestAndCopy(test: Path, testCopy: Path): Boolean { | |||
| val testCopyPath = testCopy.relativeTo(FileSystem.SYSTEM_TEMPORARY_DIRECTORY) | |||
There was a problem hiding this comment.
Could you also write a comments, why do we calculate paths in this way?
Some words like: testCopyPath stored in tmpDir, holdind the whole hierarchy of original file
while test file comes to us with path , starting from testRootPath, so we compare them in such way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #473