Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make publish... tasks depend on sign... tasks #503

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Make publish... tasks depend on sign... tasks #503

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd8c561
Attempt to feed `Provider` into `publication.artifact`
petertrr Feb 22, 2023
13f569b
Experiment with workflow
petertrr Feb 22, 2023
0949069
Experiment take 2; also fix email
petertrr Feb 22, 2023
3c66731
Revert trigger
petertrr Feb 22, 2023
477a257
Diktat fix
petertrr Feb 22, 2023
e856f59
Merge remote-tracking branch 'origin/bugfix/gradle-publishing' into b…
petertrr Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/PublishingConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@ import org.gradle.api.publish.PublishingExtension
import org.gradle.api.publish.maven.MavenPublication
import org.gradle.api.publish.maven.plugins.MavenPublishPlugin
import org.gradle.api.publish.maven.tasks.AbstractPublishToMaven
import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
import org.gradle.api.tasks.bundling.Jar
import org.gradle.kotlin.dsl.apply
import org.gradle.kotlin.dsl.configure
import org.gradle.kotlin.dsl.create
import org.gradle.kotlin.dsl.extra
import org.gradle.kotlin.dsl.getByType
import org.gradle.kotlin.dsl.register
import org.gradle.kotlin.dsl.withType
import org.gradle.nativeplatform.platform.internal.DefaultNativePlatform
import org.gradle.plugins.signing.Sign
import org.gradle.plugins.signing.SigningExtension
import org.gradle.plugins.signing.SigningPlugin

Expand Down Expand Up @@ -83,9 +85,9 @@ fun Project.configurePublishing() {
}
}

@Suppress("TOO_LONG_FUNCTION")
@Suppress("TOO_LONG_FUNCTION", "GENERIC_VARIABLE_WRONG_DECLARATION")
private fun Project.configurePublications() {
val dokkaJar: Jar = tasks.create<Jar>("dokkaJar") {
val dokkaJarProvider = tasks.register<Jar>("dokkaJar") {
Fixed Show fixed Hide fixed
group = "documentation"
archiveClassifier.set("javadoc")
from(tasks.findByName("dokkaHtml"))
Expand All @@ -95,7 +97,7 @@ private fun Project.configurePublications() {
mavenLocal()
}
publications.withType<MavenPublication>().forEach { publication ->
publication.artifact(dokkaJar)
publication.artifact(dokkaJarProvider)
publication.pom {
name.set(project.name)
description.set(project.description ?: project.name)
Expand All @@ -111,7 +113,7 @@ private fun Project.configurePublications() {
developer {
id.set("petertrr")
name.set("Petr Trifanov")
email.set("peter.trifanov@mail.ru")
email.set("peter.trifanov@gmail.com")
}
developer {
id.set("akuleshov7")
Expand All @@ -134,6 +136,13 @@ private fun Project.configureSigning() {
logger.lifecycle("The following publications are getting signed: ${extensions.getByType<PublishingExtension>().publications.map { it.name }}")
sign(*extensions.getByType<PublishingExtension>().publications.toTypedArray())
}

tasks.withType<PublishToMavenRepository>().configureEach {
kgevorkyan marked this conversation as resolved.
Show resolved Hide resolved
// Workaround for the problem described at https://github.com/saveourtool/save-cli/pull/501#issuecomment-1439705340.
// We have a single Javadoc artifact shared by all platforms, hence all publications depend on signing of this artifact.
// This causes weird implicit dependencies, like `publishJsPublication...` depends on `signJvmPublication`.
dependsOn(tasks.withType<Sign>())
}
}

private fun Project.configureNexusPublishing() {
Expand Down