Remove *_until-style iteration methods.
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This style/convention is a legacy from an old version of the Savi language, in which yield blocks could not be "jumped out of". Now that `return`, `error!`, and `break` can all jump out of a yield block, the pattern (of allowing the caller to yield back a `Bool` to indicate whether iteration should continue) is obsolete, and should be removed to reduce complexity and maintenance burden.
|
MacOS CI is failing only because of a Cirrus CI monthly cost exhaustion in the main Savi repo (the MacOS binaries there failed to publish). Merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This style/convention is a legacy from an old version of the Savi language, in which yield blocks could not be "jumped out of".
Now that
return,error!, andbreakcan all jump out of a yield block, the pattern (of allowing the caller to yield back aBoolto indicate whether iteration should continue) is obsolete, and should be removed to reduce complexity and maintenance burden.