Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es_NI currency #276

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Add es_NI currency #276

merged 3 commits into from
Oct 25, 2019

Conversation

williamjmorenor
Copy link
Contributor

@williamjmorenor williamjmorenor commented Oct 13, 2019

Signed-off-by: William José Moreno Reyes williamjmorenor@gmail.com

Changes proposed in this pull request:

    modified:   num2words/__init__.py
    new file:   num2words/lang_ES_NI.py

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

python bin/num2words 1 -l es_NI --to currency
un córdoba con cero centavos

python bin/num2words 1.02 -l es_NI --to currency
un córdoba con dos centavos

python bin/num2words 2.02 -l es_NI --to currency
dos córdobas con dos centavos

python bin/num2words 1.01 -l es_NI --to currency
un córdoba con un centavo

Additional notes

Please add support for Nicaragua Currency

Examples:

  python bin/num2words 1 -l es_NI --to currency
  un córdoba con cero centavos

  python bin/num2words 1.02 -l es_NI --to currency
  un córdoba con dos centavos

  python bin/num2words 2.02 -l es_NI --to currency
  dos córdobas con dos centavos

  python bin/num2words 1.01 -l es_NI --to currency
  un córdoba con un centavo

Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
@coveralls
Copy link

coveralls commented Oct 13, 2019

Pull Request Test Coverage Report for Build 740

  • 22 of 22 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 93.045%

Totals Coverage Status
Change from base Build 725: 0.08%
Covered Lines: 14871
Relevant Lines: 15708

💛 - Coveralls

@erozqba
Copy link
Collaborator

erozqba commented Oct 16, 2019

🙏 add tests for these changes.

Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Add a test to check correct error raises

This is a simple test to check that NotImplementedError raises
fine. This also should improve test code coverage.
@erozqba erozqba merged commit 3cb0b40 into savoirfairelinux:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants