[ADD] num2words: add traslation to spanish of several currencies #356

fernandahf · 2020-12-23T18:10:04Z

Changes proposed in this pull request:

In spanish, only translated in few currencies but with this change, we have more currencies to use.

Status

[X ] READY

How to verify this change

Run test, add three cases of added currencies.

coveralls · 2020-12-23T18:32:00Z

Pull Request Test Coverage Report for Build 968

640 of 640 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 95.849%

Totals
Change from base Build 950:	0.5%
Covered Lines:	6003
Relevant Lines:	6187

💛 - Coveralls

fernandahf · 2020-12-24T01:36:54Z

@moylop260

Could you review this, please?

Regards.

moylop260

@fernandahf

Could you test in spanish with all odoo currencies, please?
In order to check if we are not missing something

moylop260 · 2020-12-24T03:41:58Z

num2words/lang_ES.py

        'PEN': (('sol', 'soles'), ('céntimo', 'céntimos')),
+        'CRC': (('colon', 'colones'), GENERIC_CENTS),


colón

Suggested change

'CRC': (('colon', 'colones'), GENERIC_CENTS),

'CRC': (('colón', 'colones'), GENERIC_CENTS),

moylop260 · 2020-12-27T02:41:56Z

@fernandahf

I just ran the following script, check the output too in the same link:

https://gist.github.com/moylop260/a821b38e9e98e1e9168e715a248bea76

There are errors using a few currencies.

Could you fix it, please?

moylop260 · 2020-12-27T02:50:23Z

tests/test_en.py

@@ -131,6 +131,194 @@ def test_to_currency(self):
            "four pesos and one cent"
        )

+        self.assertEqual(


the name of the file is test_en.py it is for English.

What about using a *es.py ?

You right, it's fixed.

fernandahf · 2020-12-30T00:32:35Z

@fernandahf

I just ran the following script, check the output too in the same link:
* https://gist.github.com/moylop260/a821b38e9e98e1e9168e715a248bea76
There are errors using a few currencies.

Could you fix it, please?

I added all currencies except following:

BAM
QTQ
SOD

No information found about those currencies.

Regards.

moylop260 · 2020-12-30T14:58:58Z

QTQ

Check the data file directly from odoo:

https://github.com/odoo/odoo/blob/b7fa0cfad03a8319f03c1aa89eb67635e1200f67/odoo/addons/base/data/res_currency_data.xml#L765

fernandahf · 2020-12-30T20:50:16Z

QTQ

Check the data file directly from odoo:

* https://github.com/odoo/odoo/blob/b7fa0cfad03a8319f03c1aa89eb67635e1200f67/odoo/addons/base/data/res_currency_data.xml#L765

Done

moylop260 · 2021-01-07T17:45:19Z

@erozqba @toofun666

Could you check it, please?

cc @eilst

luisg123v

Traslations -> translations
The conventions [ADD], [FIX], etc; belon to Odoo, I'd try to conform guidelines from this project instead.

luisg123v · 2021-01-07T17:58:03Z

tests/test_es.py

+)
+
+TEST_CASES_TO_CURRENCY_GBP = (
+    (1.00, 'un libra con cero pence'),


Is "un" instead of "una" expected?

No, it's not expected. It's fixed.

luisg123v · 2021-01-07T18:03:52Z

num2words/lang_ES.py

+        'YER': (('rial', 'riales'), ('fils', 'fils')),
+        'YUM': (('dinar', 'dinares'), ('para', 'para')),
+        'ZMW': (('kwacha', 'kwachas'), ('ngwee', 'ngwee')),
+        'ZRZ': (('zaire', 'zaire'), ('likuta', 'makuta')),


Isn't "zaires" the plural?

You right. It's fixed.

eilst · 2021-01-09T11:39:10Z

@lgharib Could you check it, please?

fernandahf · 2021-01-18T16:34:00Z

@luisg123v

Could you review again, please?

Regards.

erozqba

@fernandahf I think we don't need to loop over the CURRENCIES_UNA. Could you also please rebase your branch?

num2words/lang_ES.py

fernandahf changed the title ~~[ADD] num2words: add traslation to spanish of several currencies~~ Add traslation to spanish of several currencies Dec 23, 2020

fernandahf changed the title ~~Add traslation to spanish of several currencies~~ [ADD] num2words: add traslation to spanish of several currencies Dec 23, 2020

moylop260 reviewed Dec 24, 2020

View reviewed changes

fernandahf force-pushed the master-add-traslation-spanish-currencies-fer branch from 25e6f46 to 6426543 Compare December 26, 2020 18:42

moylop260 reviewed Dec 27, 2020

View reviewed changes

fernandahf force-pushed the master-add-traslation-spanish-currencies-fer branch 2 times, most recently from ab3480e to ae35a48 Compare December 30, 2020 00:24

fernandahf force-pushed the master-add-traslation-spanish-currencies-fer branch from ae35a48 to 3290be5 Compare December 30, 2020 20:49

luisg123v suggested changes Jan 7, 2021

View reviewed changes

fernandahf force-pushed the master-add-traslation-spanish-currencies-fer branch 4 times, most recently from 6300de1 to 2fb7870 Compare January 7, 2021 21:28

eilst previously approved these changes Jan 9, 2021

View reviewed changes

mromdhane self-requested a review January 21, 2021 22:48

erozqba reviewed Jan 24, 2021

View reviewed changes

num2words/lang_ES.py Outdated Show resolved Hide resolved

fernandahf dismissed eilst’s stale review via 2841f48 January 25, 2021 20:25

fernandahf force-pushed the master-add-traslation-spanish-currencies-fer branch from 199d27d to 2841f48 Compare January 25, 2021 20:25

Add translations to spanish of several currencies

b0f2ccd

fernandahf force-pushed the master-add-traslation-spanish-currencies-fer branch from 49ee41f to b0f2ccd Compare January 25, 2021 20:35

Merge branch 'master' into master-add-traslation-spanish-currencies-fer

390960e

erozqba approved these changes Jan 26, 2021

View reviewed changes

mrodriguezg1991 merged commit 400917a into savoirfairelinux:master Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] num2words: add traslation to spanish of several currencies #356

[ADD] num2words: add traslation to spanish of several currencies #356

fernandahf commented Dec 23, 2020

coveralls commented Dec 23, 2020 •

edited

Loading

fernandahf commented Dec 24, 2020

moylop260 left a comment

moylop260 Dec 24, 2020

fernandahf Dec 26, 2020

moylop260 commented Dec 27, 2020

moylop260 Dec 27, 2020

fernandahf Dec 30, 2020

fernandahf commented Dec 30, 2020

moylop260 commented Dec 30, 2020

fernandahf commented Dec 30, 2020

moylop260 commented Jan 7, 2021

luisg123v left a comment

luisg123v Jan 7, 2021

fernandahf Jan 7, 2021

luisg123v Jan 7, 2021

fernandahf Jan 7, 2021

eilst commented Jan 9, 2021

fernandahf commented Jan 18, 2021

erozqba left a comment •

edited

Loading

		'PEN': (('sol', 'soles'), ('céntimo', 'céntimos')),
		'CRC': (('colon', 'colones'), GENERIC_CENTS),

	'CRC': (('colon', 'colones'), GENERIC_CENTS),
	'CRC': (('colón', 'colones'), GENERIC_CENTS),

[ADD] num2words: add traslation to spanish of several currencies #356

[ADD] num2words: add traslation to spanish of several currencies #356

Conversation

fernandahf commented Dec 23, 2020

Changes proposed in this pull request:

Status

How to verify this change

coveralls commented Dec 23, 2020 • edited Loading

Pull Request Test Coverage Report for Build 968

💛 - Coveralls

fernandahf commented Dec 24, 2020

moylop260 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moylop260 commented Dec 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fernandahf commented Dec 30, 2020

moylop260 commented Dec 30, 2020

fernandahf commented Dec 30, 2020

moylop260 commented Jan 7, 2021

luisg123v left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eilst commented Jan 9, 2021

fernandahf commented Jan 18, 2021

erozqba left a comment • edited Loading

Choose a reason for hiding this comment

coveralls commented Dec 23, 2020 •

edited

Loading

erozqba left a comment •

edited

Loading