Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #435 [pt_BR] Issue with the hundreds of millions, billions, ... when the hundreds of those are exact. #436

Merged
merged 9 commits into from
Aug 19, 2022
Merged

Fixes #435 [pt_BR] Issue with the hundreds of millions, billions, ... when the hundreds of those are exact. #436

merged 9 commits into from
Aug 19, 2022

Conversation

Daniel-EST
Copy link
Contributor

@Daniel-EST Daniel-EST commented Jan 28, 2022 •
edited
Loading

Fixes #435

Changes proposed in this pull request:

  • Fixes wrong usage of 'cento' when number are multiples of 1000 above one hundred million
  • Adds new tests

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

>>> nums = [100000000, 100000000000, 100000000000000, 100000000000000000]
>>> for num in nums:
...    num2words(num, lang="pt_BR")
...
'cem milhões'
'cem bilhões'
'cem trilhões'
'cem quatrilhões'

Cris140 and others added 5 commits October 28, 2021 14:53
@Cris140
Update lang_PT_BR.py
84e6322
Fixes #435
74ba6ee
Tests fix for issue #435
31a250e
Merge pull request #1 from Cris140/master
5f2c988 
To fix a problem in Brazilian Portuguese code referred to thousands when the hundreds are exact.
@mrodriguezg1991
Merge branch 'master' into master
4136338
@coveralls
Copy link

coveralls commented Aug 4, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 96.553% when pulling 0121931 on Daniel-EST:master into b28fb08 on savoirfairelinux:master.

@mrodriguezg1991 mrodriguezg1991 merged commit a218b33 into savoirfairelinux:master Aug 19, 2022
Daniel-EST added a commit to Daniel-EST/shu that referenced this pull request Apr 1, 2023
@Daniel-EST
feat: updates num2words dependency Ref: savoirfairelinux/num2words#436
5799945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodriguezg1991 mrodriguezg1991 mrodriguezg1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pt_BR] Issue with the hundreds of millions, billions, ... when the hundreds of those are exact.
4 participants
@Daniel-EST @coveralls @mrodriguezg1991 @Cris140