Add gender and morphological cases support for Ukrainian #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two parameters: gender and case gender can accept either 'masculine' (default) or 'feminine' case can accept either 'nominative' (default) or 'genitive','dative','accusative','instrumetnal','locative' and 'vocative'. This parameters now working only for to='cardinal'
|
@mrodriguezg1991 can I bring your attention to this PR? Do you think this is valuable addition? |
|
I reformat source code |
|
I reformat tests. Did not realize that I should check them, I cannot replicate setup locally, since I use venv and it create false positives for me somehow. |
|
What's my next steps? I see coverage setting go down only in Vietnamese which I did not touch. Is this some infra problem? |
mrodriguezg1991
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two parameters: gender and case
gender can accept either 'masculine' (default) or 'feminine' case can accept either 'nominative' (default) or
'genitive','dative','accusative','instrumetnal','locative' and 'vocative'.
This parameters now working only for to='cardinal'
Changes proposed in this pull request:
Status
How to verify this change
Personally I use this one website https://vshkole.in.ua/vidminiuvannia-chislivnikiv/
I can lookup at more interesting English sources, but it will take time. Also I will try ask for help from local NLP community if that's helpful.
Additional notes
Slavik languages can have varying forms for words based on grammatic case and gender, so if attempt to convert numbers embedded in the sentence accounting for the form is required. I assume that it's responsibility of the caller to properly identify case and gender of related words.