Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Tetum Language #576

Merged
merged 101 commits into from
Sep 20, 2024
Merged

Adding Tetum Language #576

merged 101 commits into from
Sep 20, 2024

Conversation

PeteCoward
Copy link
Contributor

@PeteCoward PeteCoward commented May 25, 2024 •
edited
Loading

Changes proposed in this pull request:

Status

  • READY
  • HOLD
  • [] WIP (Work-In-Progress)

How to verify this change

Run the tests, or build and run num2words -l tet 101

PeteCoward and others added 30 commits March 16, 2024 10:07
@PeteCoward
Initial Tetum copy of PT
07283cd
@PeteCoward
ida too sanulu
0f54073
@PeteCoward
Up to 999?
d5fd4b6
@PeteCoward
up to 9999?
a401530
@marobo
up to 100000
d4c19db
@eraulo
up to 19000000000
e02cc67
@eraulo
change milaun to millaun
be5479f
@eraulo
add trillaun rua
751e1b6
@eraulo
up to 145254635102
1f9caa2
@eraulo
changed trillaun an billaun
42ac30f
@eraulo
changed iliao to illaun
f3bab15
@eraulo
millaun change to miliaun
9d53020
@eraulo
rm paramenter inside super
ef4d092
@eraulo
add more 'miliaun','biliaun','triliaun'
efea5df
@eraulo
up to -1234567
bc8f63f
@eraulo
up to 2345.75
babef4b
@eraulo
remove parameter inside super
9593ac0
@eraulo
changed e to resin
75db3e6
@eraulo
changed o to u
24f6391
@eraulo
implemented test cardinal float
9431b43
@eraulo
add test ordinal
54c7fb6
@eraulo
changed antes de Cristo to antes Kristu
889bff2
@eraulo
changed format
5670b9e
@eraulo
add 145254635102 testing
c2f5a7a
@eraulo
add test currency integer
f162464
@eraulo
add test currency integer negative
60b46d0
@eraulo
add test currency float
ceb9129
@eraulo
add test year negative
40021a2
@eraulo
add test currency float negative
af3370b
@eraulo
rm skip
6be05c9
@coveralls
Copy link

coveralls commented May 30, 2024 •
edited
Loading

Coverage Status

coverage: 97.864% (+0.07%) from 97.794%
when pulling dfdfa0c on pykafe:lang_TET_base
into ffebd91 on savoirfairelinux:master.

PeteCoward and others added 17 commits June 1, 2024 10:38
@PeteCoward
First small increases in coverage of TET
6467799
@PeteCoward
flake8 removing unused import
92957a1
@marobo
removed lines that doesn't execute test
0967414
@MarioAP
removed anos line of code
2d2f3bb
@marobo
removed unuse codes
4648fbd
@PeteCoward
Merge pull request #27 from pykafe/lang_TET_coverage_ony
eccefb9 
Lang tet coverage ony, fix line 157 and 175
@PeteCoward
Remove unused code in to_ordinal
5857212
@PeteCoward
assert raises ordinal tests
8bdaa11
@PeteCoward
Remove if statement that was always true
0920efd
@eraulo
rm the code
c1edf90
@eraulo
Merge pull request #26 from pykafe/lang_TET_coverage_mario
7ebbb48 
removed anos line of code
@eraulo
Merge branch 'lang_TET_coverage' into rm_code_130
b4ba97c
@eraulo
Merge pull request #28 from pykafe/rm_code_130
1bb1e41 
rm the code
@eraulo
rm assert int(value)
f3333a1
@eraulo
Merge pull request #25 from pykafe/lang_TET_coverage
e67b728 
First small increases in coverage of TET
@eraulo
fixed the failing error
38dda75
@eraulo
Merge pull request #29 from pykafe/lang_TET_fail_isort
93f0f58 
fixed the failing error
@PeteCoward
Copy link
Contributor Author

PeteCoward commented Jun 15, 2024 •
edited
Loading

Hello, we are a bit puzzled by the coverage results we get here!

When we run too locally we get 100% coverage for the lang_TET.py file, and the detail links report 100% on that file too.
This reports an increase in 3.12 and 3.7 and coveralls, but a decrease in 3.8, .3.9, 3.10, 3.11 and we do not understand why.

Can anyone help us?

@mrodriguezg1991
Copy link
Contributor

@PeteCoward Hello, can you update the PR and fix the error in the tests?
Thanks for you contribution to the project

mrodriguezg1991
mrodriguezg1991 requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mrodriguezg1991 mrodriguezg1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to include bin/num2words file on commit, Can be checkout

bin/num2words Outdated Show resolved Hide resolved
bin/num2words Outdated Show resolved Hide resolved
bin/num2words Outdated Show resolved Hide resolved
@mrodriguezg1991 mrodriguezg1991 merged commit e5aee87 into savoirfairelinux:master Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodriguezg1991 mrodriguezg1991 mrodriguezg1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PeteCoward @coveralls @mrodriguezg1991 @marobo @eraulo @MarioAP @joanico