Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Tunisian Dinar #593

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

rochdi80tn
Copy link
Contributor

@rochdi80tn rochdi80tn commented Nov 9, 2024

Fixes # by...

Changes proposed in this pull request:

  • Added support to Tunisian Dinars currency amount to letters for arabic language
    So someone can use this syntax to get proper tunisinan currency amount in words.
    amount_in_words = num2words(amount, lang='ar', to='currency', currency='TND')

Status

  • READY
  • HOLD
  • [] WIP (Work-In-Progress)

How to verify this change

use the above stated example

@rochdi80tn
Copy link
Contributor Author

Hello,
Who can review and approve this PR please ?

@coveralls
Copy link

coveralls commented Nov 18, 2024

Coverage Status

coverage: 98.052% (+0.001%) from 98.051%
when pulling 774576c on rochdi80tn:master
into 0df2a0e on savoirfairelinux:master.

@mrodriguezg1991
Copy link
Contributor

mrodriguezg1991 commented Nov 19, 2024

Hello, Who can review and approve this PR please ?

Helloo
Thanks for contributing to the project
The change seems ok, however because you added new lines the test coverage decreased, please add new tests to validate the changes

@rochdi80tn
Copy link
Contributor Author

rochdi80tn commented Nov 24, 2024

Hi @mrodriguezg1991,
Tests updated to fix coverage.

@rochdi80tn
Copy link
Contributor Author

Hello
I need this PR change in a production system. Do you know when this could be merged and released? Is there a schedule for releases ?
Thank you.
BR
Rochdi

@mrodriguezg1991 mrodriguezg1991 merged commit 282f72d into savoirfairelinux:master Dec 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants