Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soap action can be set via the :soap_action key. #263

Merged
merged 1 commit into from
Feb 17, 2012

Conversation

hoverlover
Copy link
Contributor

Currently, the symbol you pass to the Savon::Client#request method is used in both looking up the soap action in the WSDL, as well as creating the first element in the soap body. I'm using a service who's first element of the soap body is not the same as the soap action's name. As far as I could tell, there was no easy way to accomplish this with the current code base.

One possibility is explicitly setting the SOAPAction header inside the request block, after the preconfigure has ran. I didn't like that option because the WSDL already has the soap action, and I don't like repeating it in the code. I like the automatic lookup that happens when you pass in a symbol.

For this reason, I've added a :soap_action option in the hash parameter of the #request method. Having the soap action name and first element of the soap body being different probably goes against the standard, but there are services out there that are written this way, and there was no "easy" way to do this with Savon.

rubiii added a commit that referenced this pull request Feb 17, 2012
Soap action can be set via the :soap_action key.
@rubiii rubiii merged commit 262de7c into savonrb:master Feb 17, 2012
@rubiii
Copy link
Contributor

rubiii commented Feb 17, 2012

thanks chad!

@rubiii
Copy link
Contributor

rubiii commented Feb 17, 2012

released with v0.9.9

@cboyd-iseatz
Copy link

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants