Fix namespaces not being properly added to arrays. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SOAP request body is passed as a hash, one may specify the value for a key to be an array of hashes. In this case, each hash in the array is treated as being contained within a element specified by the key. The namespace applied to the elements specified within the array was previously the default namespace. This fix recursively determines the proper namespaces for these elements. - Modifiy lib/savon/soap/xml.rb to recursively determine proper namespaces for elements contained within arrays - Modifiy spec/fixtures/wsdl/multiple_namespaces.xml to add a new operation that properly exhibits the problem - Modifiy spec/savon/client_spec.rb to add a new test that exhibits the problem - Modifiy spec/savon/client_spec.rb to change an old test that failed after the change. The failure was not a regression. In this case, the same namespace was applied but with a different namespace name.
|
|
||
| it "should namespaces each Array item as expected" do | ||
| HTTPI::Request.any_instance.expects(:body=).with do |value| | ||
| value.include?("<ins0:cartItems><ins0:CartItem>") && value.include?("<tns:ItemID>SKU-TEST</tns:ItemID>") |
There was a problem hiding this comment.
These hardcoded namespace references caused this test to fail after my patch. tns and ins0 actually refer to the same namespace. After my patch, ItemID will be namespaced by ins0 rather than tns. This change occurs because previously this element was just using the default namespace name. Note that the correctness of using tns or ins0 is the same, so I just generalized the test by referring to the actual namespace URI, rather than its name.
jkingdon
added a commit
that referenced
this pull request
Aug 16, 2012
Fix namespaces not being properly added to arrays.
|
released with v1.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SOAP request body is passed as a hash, one may specify the
value for a key to be an array of hashes. In this case, each hash
in the array is treated as being contained within a element specified by
the key. The namespace applied to the elements specified within the
array was previously the default namespace. This fix recursively
determines the proper namespaces for these elements.
namespaces for elements contained within arrays
operation that properly exhibits the problem
problem
after the change. The failure was not a regression. In this case, the
same namespace was applied but with a different namespace name.