Refactor building of SOAP::Request instances into a separate class. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue #259 (Savon::Client and threadsafety) by isolating the building of SOAP::Request instances outside of the Client. - Add SOAP::RequestBuilder class and its spec. - Modify Client to to build requests using RequestBuilder. - Modify Client spec to reflect changes in its functionality. - Add integration test to verify threadsafety.
|
looks like I used 1.9 lambda syntax, which is causing the build to fail on 1.8. i'll fix this and update the PR. |
|
this is one of the most awesome pull requests i've ever seen. thank you very much! |
|
thanks, daniel! let me know if you spot any problems... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #259 (Savon::Client and threadsafety) by isolating the
building of SOAP::Request instances outside of the Client.