Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a #servicename method hooked on Wasabi::Document#servicename. #408

Closed
wants to merge 1 commit into from

Conversation

keltia
Copy link
Contributor

@keltia keltia commented Mar 14, 2013

This is the link between Savon and Wasabi (see savonrb/wasabi#22).
Can be overridden by global options.

@rubiii
Copy link
Contributor

rubiii commented Mar 14, 2013

thanks @keltia. two things:

  1. as the service name is not used internally, why would you need a global overwrite?
  2. i'm not sure whether the #servicename method should be exposed through the client or if it would make sense to add another "layer" and exposes some kind of service object which can be asked for its name and operations. give me a moment to think about this.

@keltia
Copy link
Contributor Author

keltia commented Mar 15, 2013

@rubiii I'm not sure the client interface is the right way to expose no but as @wsdl has no accessor, I have no choice for now. I'm not sure about the global overwrite, it just seems interesting to me to be able to change it. My goal is, as I told on Twitter, to be able to generate some kind of proxy class for the service and having the service name available is better than trying to guess it through the filename in my personal case.

@rubiii
Copy link
Contributor

rubiii commented Mar 19, 2013

@keltia i understand. so you would be fine with removing the global option, because all your services have a name?!

@rubiii rubiii closed this in 1af0d38 Apr 21, 2013
@rubiii
Copy link
Contributor

rubiii commented Apr 21, 2013

merged your changes, renamed the method to service_name and pushed the changes to master.
this will be released with v2.2.0. thanks @keltia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants