Refactor #138
Merged
Refactor #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savq
force-pushed
the
dev
branch
2 times, most recently
from
23998a0
to
3fb861e
Compare
savq
force-pushed
the
dev
branch
3 times, most recently
from
e9191c5
to
75fe69c
Compare
- Rename `check_rm` to `find_unlisted` and refactor.
- NOTE: It'd be simplified further with `vim.fs.dir`, but that
requires nvim v0.8.
- Rename `walk_dir` to `walkdir` and refactor to return an iterator
instead of taking a function.
savq
force-pushed
the
dev
branch
3 times, most recently
from
7dca76d
to
d7ee677
Compare
- Refactor `list` function - Refactor `report` to contain the `messages` table, since it's not used anywhere else. - Prefer calling `string.format` function to `:format` method. - Prefer omitting parentheses when passing a single table argument.
savq
force-pushed
the
dev
branch
2 times, most recently
from
bff8802
to
acc3e87
Compare
- Add description for `url_format` setup option. - Format code snippets in docs. - Indent at 2 spaces - Use double quotes - Elide parentheses for single table arguments - Rewrite the section on bootstrapping. - Update CONTRIBUTING to mention the issue template. - Update the descriptions of package options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_rmtofind_unlistedand refactor.walk_dirtowalkdirand refactor to return an iterator instead of taking a function.reportto contain themessagestable, since it's not used anywhere else.listfunction.registerfunction to simplify name inference.parse_namefunction.string.formatfunction to:formatmethod.Docs
url_formatsetup option.walkdirwas based on Julia'sFilesystem.walkdir.find_unlistedcould be simplified further withvim.fs.dir, but that requires nvim v0.8.