Allow users to pass a username to defined resource #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the initial commit in 1fbf6a7: this allows us to use this defined type as often as we want (which is the purpose of a defined type). Each usage of it creates an entry in $user/.ssh/config. This is not a breaking change since you can still use the resource as before. However, you can now call it multiple types by setting a unique name for it + providing user => $user as a parameter. Use case: define a block in each puppet profile you have. Notice: I needed to bump the concat dependency by a major release, this means that the next release of this software also should be a major one, even if the API of this module has no breaking changes. To use this feature it's required to call the defined resource multiple times. That requires different names for it. We cannot assume that the name of the defined resource is always a valid user.
|
I'm a bit confused why I changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the initial commit in 1fbf6a7:
this allows us to use this defined type as often as we want (which is
the purpose of a defined type). Each usage of it creates an entry in
$user/.ssh/config. This is not a breaking change since you can still use
the resource as before. However, you can now call it multiple types by
setting a unique name for it + providing user => $user as a parameter.
Use case: define a block in each puppet profile you have.
Notice: I needed to bump the concat dependency by a major release, this
means that the next release of this software also should be a major one,
even if the API of this module has no breaking changes.
To use this feature it's required to call the defined resource multiple
times. That requires different names for it. We cannot assume that the
name of the defined resource is always a valid user.