Skip to content

Commit

Permalink
fix(angular/select): remove incompatible aria-autocomplete attribute (#…
Browse files Browse the repository at this point in the history
…2384)

Fixes a bug where the usage of aria-autocomplete is not a valid attribute that can be used with aria role=listbox. Removes the aria-autocomplete attribute to fix the violation: aria-allowed-attr.
  • Loading branch information
mhaertwig authored and github-actions committed Sep 23, 2024
1 parent 9262018 commit 8700ea8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/angular/select/select.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,6 @@ describe('SbbSelect', () => {

it('should set the role of the select to combobox', () => {
expect(select.getAttribute('role')).toEqual('combobox');
expect(select.getAttribute('aria-autocomplete')).toBe('none');
expect(select.getAttribute('aria-haspopup')).toBe('listbox');
});

Expand Down
1 change: 0 additions & 1 deletion src/angular/select/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ const _SbbSelectMixinBase = mixinVariant(
changeDetection: ChangeDetectionStrategy.OnPush,
host: {
role: 'combobox',
'aria-autocomplete': 'none',
'aria-haspopup': 'listbox',
class: 'sbb-select sbb-input-element',
'[attr.id]': 'id',
Expand Down

0 comments on commit 8700ea8

Please sign in to comment.