Skip to content

Commit

Permalink
Bump min node version to 18.20.3
Browse files Browse the repository at this point in the history
  • Loading branch information
sbc100 committed May 28, 2024
1 parent 58d39a5 commit 9bc8428
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ orbs:
executors:
linux-node:
docker:
- image: circleci/node:stretch
- image: cimg/node:18.20.3
linux-python:
docker:
- image: cimg/python:3.10.7
Expand Down
7 changes: 4 additions & 3 deletions src/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -1905,10 +1905,11 @@ var MIN_CHROME_VERSION = 85;

// Specifies minimum node version to target for the generated code. This is
// distinct from the minimum version required run the emscripten compiler.
// This version aligns with the current Ubuuntu TLS 20.04 (Focal).
// Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
// This version aligns with the current Node LTS release, and the version
// of node that is including with emsdk.
// Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.1.
// Minimum supported value is 101900, which was released 2020-02-05.
var MIN_NODE_VERSION = 160000;
var MIN_NODE_VERSION = 182003;

// Whether we support setting errno from JS library code.
// In MINIMAL_RUNTIME builds, this option defaults to 0.
Expand Down
2 changes: 1 addition & 1 deletion tools/shared.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
# (settings.MIN_NODE_VERSION).
# This version currently matches the node version that we ship with emsdk
# which means that we can say for sure that this version is well supported.
MINIMUM_NODE_VERSION = (16, 20, 0)
MINIMUM_NODE_VERSION = (18, 20, 3)
EXPECTED_LLVM_VERSION = 19

# These get set by setup_temp_dirs
Expand Down

0 comments on commit 9bc8428

Please sign in to comment.