Remove instance methods module #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Sam, Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sam,
Appreciate your putting together the zencodable gem. Started using it in a project using Rails 3.2.6 on Ruby 1.9.3 and was seeing warnings about ActiveRecord::Concern::InstanceMethods being deprecated, so figured I'd just patch to avoid the warnings.
In order to get all the tests running properly, I also needed to specify the version for the sqlite gem in the .gemspec file, and create a migration to add the zencoder_job_id field to the videos table in the dummy app.
All tests are passing after my changes.
Best,
Jeff