Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notebook by changing mcmc parameters #1058

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

zinaStef
Copy link
Contributor

@zinaStef zinaStef commented Mar 20, 2024

Fixed tutorial notebook 14 14_iid_data_and_permutation_invariant_embeddings, which was failing in cell 12.

The problem was that the sampler produced samples that had inf value (see issue #1060) and the pair_plot function was failing when computing the x-axis max limit based on the samples (see issue #1059). To solve it I changed the warmup parameter of the mcmc

mcmc_parameters = dict(
    num_chains=50,
    thin=5,
    warmup_steps=30, # before 10
    init_strategy="proposal",
)
mcmc_method = "slice_np_vectorized"

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read and understood the contribution
    guidelines
  • I agree with re-licensing my contribution from AGPLv3 to Apache-2.0.
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have reported how long the new tests run and potentially marked them
    with pytest.mark.slow.
  • New and existing unit tests pass locally with my changes
  • I performed linting and formatting as described in the contribution
    guidelines
  • I rebased on main (or there are no conflicts with main)

@manuelgloeckler manuelgloeckler merged commit 5aa228f into main Mar 20, 2024
3 checks passed
@zinaStef zinaStef deleted the 1037-tutorial_14 branch March 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants