Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tutorials: remove outputs from tutorials. #1266

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Sep 4, 2024

  • small fixes to getting_started tutorial

  • I wrote a custom nb preprocessor that strips everything except plots and prints from all notebooks.

  • I will add this script to CI for building the docs in a separate PR.

@janfb janfb changed the title Refactor tutorials Refactor tutorials: remove outputs from tutorials. Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (8afd985) to head (b928a91).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   86.05%   78.28%   -7.78%     
==========================================
  Files         118      119       +1     
  Lines        8672     8698      +26     
==========================================
- Hits         7463     6809     -654     
- Misses       1209     1889     +680     
Flag Coverage Δ
unittests 78.28% <ø> (-7.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton, this is much better!! I only had a look at 00_getting_started and left a few comments.

tutorials/00_getting_started.ipynb Outdated Show resolved Hide resolved
tutorials/00_getting_started.ipynb Outdated Show resolved Hide resolved
tutorials/00_getting_started.ipynb Outdated Show resolved Hide resolved
tutorials/00_getting_started.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now!

@janfb janfb merged commit becc93c into main Sep 5, 2024
4 checks passed
@janfb janfb deleted the refactor-tutorials branch September 5, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants