Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition error handling #1275

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Fix condition error handling #1275

merged 3 commits into from
Sep 12, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Sep 10, 2024

  • raise ValueError is a batched condition is passed to ConditionedPotential
  • refactor Decision Making example notebook.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (dbcd06b) to head (cbb167b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1275       +/-   ##
===========================================
- Coverage   89.25%   78.35%   -10.90%     
===========================================
  Files         119      119               
  Lines        8698     8708       +10     
===========================================
- Hits         7763     6823      -940     
- Misses        935     1885      +950     
Flag Coverage Δ
unittests 78.35% <100.00%> (-10.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/inference/posteriors/base_posterior.py 85.18% <ø> (-3.06%) ⬇️
sbi/inference/potentials/base_potential.py 91.66% <100.00%> (+0.75%) ⬆️
sbi/utils/conditional_density_utils.py 73.46% <100.00%> (-17.51%) ⬇️

... and 31 files with indirect coverage changes

@janfb janfb force-pushed the fix-condition-error-handling branch from 9b21a38 to cbb167b Compare September 11, 2024 13:19
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@janfb janfb merged commit d343855 into main Sep 12, 2024
6 checks passed
@janfb janfb deleted the fix-condition-error-handling branch September 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants