Minor fix for EnsemblePosterior weights.setter #1299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
In sbi.inference.posteriors, the EnsemblePosterior instantiation would return a TypeError when passing weights (torch.Tensor or List[float]). The condition
elif weights is Tensor or weights is List
would always return False, I changed the condition toelif isinstance(weights, Tensor) or isinstance(weights, List)
, where Tensor is the torch class of the same name.Does this close any currently open issues?
No, to the best of my knowledge.
Any relevant code examples, logs, error output, etc?
The only "fix" is intended to properly test the type of the weights attribute of EnsemblePosterior in case it is not None.
Any other comments?
I do not know whether I should have opened an new issue instead of doing a minor one-line PR. I will leave empty most of the Checklist items below.
...
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
guidelines
with
pytest.mark.slow
.guidelines
main
branchFor the reviewer: