Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial for Posterior Predictive Check #592

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

LouisRouillard
Copy link
Contributor

As a quick and easy inference diagnosis, a tutorial showing how the existing sbi plotting capabilities can be used to perform a Posterior Predictive Check (PPC).

@LouisRouillard
Copy link
Contributor Author

Is there any formal reference for a PPC I should be using ?

@LouisRouillard
Copy link
Contributor Author

I wonder if shifting x_o in the end instead of simulating a bad x_PP is not confusing, I can change it easily if it is the case.

@janfb
Copy link
Contributor

janfb commented Jan 24, 2022

great, thanks for this PR @LouisRouillard !

I think this looks good already! A couple of comments:

  • in pair plot you can pass upper="scatter" and scatter_offdiag=dict(...) for scatter kwargs to show posterior samples as scatter plot, which could be more intuitive here.
  • you can also pass the style for the points marker with, e.g., points_offdiag=dict(marker='+', ms=10),
  • in general, there are tons of options for pair plot, you find a overview in the default here.
  • just a small thing: I would prefer lower-case variance name, e.g., x_pp instead of x_PP

@janfb
Copy link
Contributor

janfb commented Jan 24, 2022

I think the error case is good to show and it's fine to manipulate x directly instead of constructing a misspecified one. At this point, and as a general remark at the end you could say that one would check for this failure mode by running prior predictive checks.

Copy link
Contributor Author

@LouisRouillard LouisRouillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready for merge

@michaeldeistler michaeldeistler merged commit 20d5665 into sbi-dev:main Jan 26, 2022
@michaeldeistler
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants